[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v21 11/14] x86/VPMU: Handle PMU interrupts for PV(H) guests

>>> On 18.05.15 at 18:19, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 05/18/2015 11:39 AM, Jan Beulich wrote:
>>>>> On 08.05.15 at 23:06, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/hvm/svm/vpmu.c
>>> +++ b/xen/arch/x86/hvm/svm/vpmu.c
>>> @@ -45,6 +45,7 @@ static unsigned int __read_mostly num_counters;
>>>   static const u32 __read_mostly *counters;
>>>   static const u32 __read_mostly *ctrls;
>>>   static bool_t __read_mostly k7_counters_mirrored;
>>> +static unsigned long __read_mostly ctxt_sz;
>> Can this reasonably require a long instead of just an int?
> This is assigned by sizeof() so perhaps it should rather be size_t 
> (which is an unsigned long)?
> But I can guarantee that it will fit into an int ;-)

In which case imo it should be unsigned int (we have numerous other
places where expressions of wider type get stored into more narrow
type variables), to avoid needlessly increased cache footprint.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.