Re: [Xen-devel] [PATCH v2 24/41] arm : acpi create efi node for DOM0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.05.15 at 22:03, <parth.dixit@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/efi.h
> +++ b/xen/include/xen/efi.h
> @@ -8,7 +8,7 @@
>  extern const bool_t efi_enabled;
>  
>  #define EFI_INVALID_TABLE_ADDR (~0UL)
> -
> +#define EFI_MEM_DESC_V1 1
>  /* Add fields here only if they need to be referenced from non-EFI code. */
>  struct efi {
>      unsigned long mps;          /* MPS table */
> @@ -20,6 +20,15 @@ struct efi {
>  
>  extern struct efi efi;
>  
> +struct efi_memory_desc {
> +    u32 type;
> +    u32 pad;
> +    u64 phys_addr;
> +    u64 virt_addr;
> +    u64 num_pages;
> +    u64 attribute;
> +};
> +
>  #ifndef __ASSEMBLY__
>  
>  union xenpf_efi_info;

NAK - you're supposed to use what is already there, or give a good
reason why redundant declarations are needed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel