[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 24/41] arm : acpi create efi node for DOM0

On 20 May 2015 at 21:46, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>> On 17.05.15 at 22:03, <parth.dixit@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/efi.h
> +++ b/xen/include/xen/efi.h
> @@ -8,7 +8,7 @@
>Â extern const bool_t efi_enabled;
> -
> +#define EFI_MEM_DESC_V1 1
>Â /* Add fields here only if they need to be referenced from non-EFI code. */
>Â struct efi {
>Â Â Â unsigned long mps;Â Â Â Â Â /* MPS table */
> @@ -20,6 +20,15 @@ struct efi {
>Â extern struct efi efi;
> +struct efi_memory_desc {
> +Â Â u32 type;
> +Â Â u32 pad;
> +Â Â u64 phys_addr;
> +Â Â u64 virt_addr;
> +Â Â u64 num_pages;
> +Â Â u64 attribute;
> +};
> +
>Â #ifndef __ASSEMBLY__
>Â union xenpf_efi_info;

NAK - you're supposed to use what is already there, or give a good
reason why redundant declarations are needed.

I thought efi fields that need to be refreneced from non-efi code can be added here.
Is this not correct?
Although i am rethinking about the design so that efi tables are extracted in the common efi code and passed
to non efi code as it is done in case of device tree. I'll post rfc for that would that be okay?

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.