Re: [Xen-devel] [PATCH] x86/pvh: disable posted interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.05.15 at 14:14, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -980,6 +980,10 @@ static int construct_vmcs(struct vcpu *v)
>          v->arch.hvm_vmx.secondary_exec_control &=
>              ~SECONDARY_EXEC_UNRESTRICTED_GUEST;
>  
> +        /* Disable posted interrupts */
> +        __vmwrite(PIN_BASED_VM_EXEC_CONTROL,
> +            vmx_pin_based_exec_control & ~PIN_BASED_POSTED_INTERRUPT);

To be understandable in a few months/years, this should be moved
up a few lines, and the comment should be something like "In turn,
disable posted interrupts." (Please also note the stop at its end.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel