Re: [Xen-devel] [PATCH] x86/pvh: disable posted interrupts

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Roger Pau Monne [mailto:roger.pau@xxxxxxxxxx]
> Sent: Thursday, May 21, 2015 8:15 PM
> 
> Enabling posted interrupts requires the virtual interrupt delivery feature,
> which is disabled for PVH guests, so make sure posted interrupts are also
> disabled or else vmlaunch will fail.
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Reported-and-Tested-by: Lars Eggert <lars@xxxxxxxxxx>
> Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>
> Cc: Eddie Dong <eddie.dong@xxxxxxxxx>
> Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>, if you fix the comment from Jan.

Thanks
Kevin

> ---
>  xen/arch/x86/hvm/vmx/vmcs.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> index a714549..9827a8e 100644
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -980,6 +980,10 @@ static int construct_vmcs(struct vcpu *v)
>          v->arch.hvm_vmx.secondary_exec_control &=
>              ~SECONDARY_EXEC_UNRESTRICTED_GUEST;
> 
> +        /* Disable posted interrupts */
> +        __vmwrite(PIN_BASED_VM_EXEC_CONTROL,
> +            vmx_pin_based_exec_control &
> ~PIN_BASED_POSTED_INTERRUPT);
> +
>          /* Start in 64-bit mode. PVH 32bitfixme. */
>          vmentry_ctl |= VM_ENTRY_IA32E_MODE;       /*
> GUEST_EFER.LME/LMA ignored */
> 
> --
> 1.9.5 (Apple Git-50.3)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel