Re: [Xen-devel] [RFC][v2][PATCH 10/14] tools: extend XENMEM_set_memory_map

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2015/5/22 18:25, Julien Grall wrote:
> Hi,
>
> On 22/05/2015 10:35, Tiejun Chen wrote:
> > Here we'll construct a basic guest e820 table via
> > XENMEM_set_memory_map. This table includes lowmem, highmem
> > and RDMs if they exist. And hvmloader would need this info
> > later.
> >
> > Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> > ---
> >   tools/libxl/libxl_dom.c | 87
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 87 insertions(+)
> >
> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > index 84d5465..cc4b1a6 100644
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -913,6 +913,87 @@ out:
> >       return rc;
> >   }
> >
> > +/*
> > + * Here we're just trying to set these kinds of e820 mappings:
> > + *
> > + * #1. Low memory region
> > + *
> > + * Low RAM starts at least from 1M to make sure all standard regions
> > + * of the PC memory map, like BIOS, VGA memory-mapped I/O and vgabios,
> > + * have enough space.
> > + * Note: Those stuffs below 1M are still constructed with multiple
> > + * e820 entries by hvmloader. At this point we don't change anything.
> > + *
> > + * #2. RDM region if it exists
> > + *
> > + * #3. High memory region if it exists
> > + *
> > + * Note: these regions are not overlapping since we already check
> > + * to adjust them. Please refer to libxl__domain_device_construct_rdm().
> > + */
> > +#define GUEST_LOW_MEM_START_DEFAULT 0x100000
> > +static int libxl__domain_construct_memmap(libxl__gc *gc,
> > +                                          libxl_domain_config *d_config,
> > +                                          uint32_t domid,
> > +                                          struct xc_hvm_build_args
> > *args)
> The code within this function is x86 specific. Shouldn't it be moved in
> libxl_x86.c?
Sounds reasonable.

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel