Re: [Xen-devel] [PATCH v2 02/41] arm/acpi: Build pmstat for x86 only

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Parth,

On 17/05/15 21:03, Parth Dixit wrote:
> Pmstat is currently not supported for arm in xen.
> Configure and build pmstat for x86 architecture only.
> 
> Signed-off-by: Parth Dixit <parth.dixit@xxxxxxxxxx>
> ---
>  xen/common/sysctl.c       | 2 ++
>  xen/drivers/acpi/Makefile | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> index 601dd09..96d06cf 100644
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) 
> u_sysctl)
>          op->u.availheap.avail_bytes <<= PAGE_SHIFT;
>          break;
>  
> +#ifdef CONFIG_X86

pmstat seems to be tight with cpufreq, so I would use HAS_CPUFREQ.

>  #ifdef HAS_ACPI

And combine the two #ifdef.

>      case XEN_SYSCTL_get_pmstat:
>          ret = do_get_pm_info(&op->u.get_pmstat);
> @@ -181,6 +182,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) 
> u_sysctl)
>              copyback = 1;
>          break;
>  #endif
> +#endif
>  
>      case XEN_SYSCTL_page_offline_op:
>      {
> diff --git a/xen/drivers/acpi/Makefile b/xen/drivers/acpi/Makefile
> index 7294b5a..009fe5a 100644
> --- a/xen/drivers/acpi/Makefile
> +++ b/xen/drivers/acpi/Makefile
> @@ -5,7 +5,7 @@ subdir-$(x86) += apei
>  obj-bin-y += tables.init.o
>  obj-$(x86) += numa.o
>  obj-y += osl.o
> -obj-y += pmstat.o
> +obj-$(x86) += pmstat.o

obj-$(HAS_CPUFREQ)

>  
>  obj-$(x86) += hwregs.o
>  obj-$(x86) += reboot.o
> 

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel