Re: [Xen-devel] [PATCH V5] xen/vm_event: Clean up control-register-write vm_events and add XCR0 event

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.05.15 at 18:21, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 05/26/2015 06:47 PM, Jan Beulich wrote:
>>>>> On 25.05.15 at 10:33, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/hvm/event.c
>>> +++ b/xen/arch/x86/hvm/event.c
>>> @@ -19,6 +19,7 @@
>>>  * Place - Suite 330, Boston, MA 02111-1307 USA.
>>>  */
>>>  
>>> +#include <asm/monitor.h>
>>>  #include <xen/vm_event.h>
>>>  #include <xen/paging.h>
>> 
>> Just like almost everywhere else, please have asm/ includes follow
>> xen/ ones.
> 
> Ack. I went the sorted-alphabetically route, obviously that's not the
> Xen convention.

Sorted alphabetically is generally a good idea imo, but not across
sub-directories. Having asm/ ones precede xen/ ones increases the
risk of an arch header pulling in things another, later header
requires, possibly breaking the build on the other arch where that's
not the case.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel