[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] question on "xen-blkback: enlarge the array size of blkback name"

El 27/05/15 a les 9.47, Jan Beulich ha escrit:
> Hello,
> looking at this once again now that it's upstream, I still can't see what
> this is good for: The only use the produced string has is to be passed
> to kthread_run(), i.e. ultimately to be stored in a task's ->comm. That,
> however, continues to be limited to 16 characters, so
> blkback.domid.xvd[a-z] being up to 18 characters I don't understand
> how the change results in the full name being shown. What am I
> missing?

Right, I didn't realize there was a length limitation in task_struct.
How did you manage to get it working Chentao?

> Why aren't you instead shortening the string to e.g.
> blkbk.domid.xvd[a-z] (which still is 16 characters, i.e. the last
> character would still be chopped off for 5 digit domain IDs; perhaps
> the first dot should then also be dropped).

That sounds right.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.