Re: [Xen-devel] [PATCH v2 for Xen 4.6 1/4] xen: enabling XL to set per-VCPU parameters of a domain for RTDS scheduler

[Chong Li <lichong659@xxxxxxxxx>]

On Wed, May 27, 2015 at 5:02 AM, Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> On Mon, May 25, 2015 at 07:05:52PM -0500, Chong Li wrote:

>
> I didn't see any fields you need to copy back here ('vcpus' were copied back
> in rt_vcpu_cntl() already).
>
>> +{
>> +    struct rt_private *prv = rt_priv(ops);
>> +    struct rt_dom * const sdom = rt_dom(d);
>> +    struct rt_vcpu *svc;
>> +    struct list_head *iter;
>> +    unsigned long flags;
>> +    int rc = 0;
>> +    xen_domctl_sched_rtds_params_t local_sched;
>> +    unsigned int vcpuid;
>> +    unsigned int i;
>
>  'vcpuid' is only used in 'get' path once while 'i' is used in 'set' path
>  only, perhaps merge the two variables?
>
Yes, we can use vcpuid in both cases.

>
>> +        }
>> +        spin_unlock_irqrestore(&prv->lock, flags);
>> +        break;
>
> 'nr_vcpus' is not actually used untile now but in xc side you do pass
> that in.
>
Right. nr_vcpus is just useful when it is 'set' case. I'll remove this
from the 'get' case.

> Regards
> Chao

Thanks,
Chong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel