[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [libvirt] [PATCH 0/4] libxl: support SPICE graphics

On 05/28/2015 05:10 AM, Michal Privoznik wrote:
On 09.05.2015 00:31, Jim Fehlig wrote:
This series provides support for SPICE graphics in the libxl driver.
The first patch is mostly code movement.  The second patch is a trivial
name change of a structure member.  Patch3 populates the
libxl_domain_build_info struct with SPICE info.  SPICE isn't as nice
without QXL, so patch4 provides support for QXL video device.

Jim Fehlig (4):
   libxl: populate build_info vfb in separate function
   libxl: change reservedVNCPorts to reservedGraphicsPorts
   libxl: support SPICE graphics for HVM domains
   libxl: support QXL video device

  src/libxl/libxl_conf.c   | 150 +++++++++++++++++++++++++++++++++++++----------
  src/libxl/libxl_conf.h   |   2 +-
  src/libxl/libxl_domain.c |   8 ++-
  src/libxl/libxl_driver.c |   4 +-
  4 files changed, 128 insertions(+), 36 deletions(-)

ACK to all, but please see my comment to 3/4 before pushing.

Even though we are in freeze, this has been lying around for a while
therefore I think it's safe to push these.

Thanks for the review and finding the bug in 3/4! I changed it as we discussed and pushed the series.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.