Re: [Xen-devel] [PATCH 1/4] hvmloader: Fixup pci_write* macros

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.06.15 at 16:35, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/06/15 15:30, Don Slutz wrote:
>> On 06/15/15 10:19, Andrew Cooper wrote:
>>> Furthermore, what about devfn or reg?
>>>
>> devfn and reg do not need the bracketing since they are just passed,
>> but I have no issue with adding the extra brackets.
> 
> Macros, under all circumstances, should have all of their parameters
> bracketed for safety.

No, as this harms readability:

#define macro(x) function((x))

would completely pointlessly be having an extra set of parentheses.
And

#define macro(x, y) function(x, y)

is just the logical extension to that: There is nothing the expressions
passed as arguments could contain to require parenthesization, as
there's no operator of precedence lower than comma (and if either
argument contains a comma expression, it needs to be
parenthesized at the invocation site anyway).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel