Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-06-24 at 11:29 +0100, Julien Grall wrote:

> > +    if ( virt_cmd->mapd.valid )
> > +    {
> > +        /* itt field is 40 bit. extract 48 bit address by shifting */
> > +        dt_entry.vitt_ipa = virt_cmd->mapd.itt << 8;
> > +
> > +        dt_entry.vitt_size = (1 << (virt_cmd->mapd.size + 1)) * 8;
> 
> Where does come from the 8? Is it the size of the ITT? If so, you should
> use the proper define.

sizeof(struct vitt) is what was meant, I think?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel