Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@xxxxxxxxx wrote:
[...]
> +    /* XXX: Enable validation later */
> +    vdev = find_vits_device(&v->domain->arch.vits->dev_root, dev_id);
> +    if ( !vdev && !vdev->its_dev )
> +        return -EINVAL;

vdev is unused I think. Which is good because according to the draft
spec it should never be needed here. I believe that should be the case
for all vgic_its_process_*.

Avoiding this lookup was part of the point of the major rework done in
draftC of the spec.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel