Re: [Xen-devel] [OSSTEST PATCH 03/13] Reporting: sg-report-flight: Fix undefined value in $worstrow[]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 03/13] Reporting: sg-report-flight: 
Fix undefined value in $worstrow[]"):
> On Mon, 2015-06-29 at 18:14 +0100, Ian Jackson wrote:
...
> > diff --git a/sg-report-flight b/sg-report-flight
> > index 6481521..117b609 100755
> > --- a/sg-report-flight
> > +++ b/sg-report-flight
> > @@ -965,7 +965,7 @@ END
> >  
> >      my $cell_html = sub {
> >     my ($ei, $core_only) = @_;
> > -   # => ($h, $priority);
> > +   # => ($h, $priority, $ch);
> 
> This is a 3-tuple.
> 
> >     my $s= $ei->{Step};
> >     my $sum_core= $ei->{SummaryCore};
> >     $sum_core= $ei->{Summary} if !defined $sum_core;
> > @@ -998,7 +998,7 @@ END
> >      my @worstrow1;
> >      my @worstrow2;
> >      foreach my $col (@cols) {
> > -   my @worst=(' bgcolor="#444444">',0);
> > +   my @worst=('',0,'bgcolor="#444444"','');
> 
> But this is a 4-tuple. Is there still a disconnect?
> 
> Ah no, out of context here there is a @worst=@this followed by a "push
> @worst". So this change is correct, but perhaps a comment would help
> clarify? e.g
> 
> # Result of $cell_html + Encoded string of failing stepid
> 
> ?

Good idea.  I have added a comment, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel