Re: [Xen-devel] [PATCH v2 12/15] xen/arm: gic: Store the necessary HW information per vGIC ...

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-06-30 at 15:11 +0100, Julien Grall wrote:
> On 30/06/15 15:00, Ian Campbell wrote:
> >>>> +static inline void vgic_v2_setup_hw(paddr_t dbase, paddr_t cbase,
> >>>> +                                    paddr_t vbase)
> >>>> +{
> >>>> +    vgic_v2_hw.enabled = 1;
> >>>> +    vgic_v2_hw.dbase = dbase;
> >>>> +    vgic_v2_hw.cbase = cbase;
> >>>> +    vgic_v2_hw.vbase = vbase;
> >>>> +}
> >>>
> >>> If you were to move this out of line into vgic-v2.c would that mean that
> >>> vgic_v2_hw_config etc could be static to that file?
> >>
> >> No, we have to access the field enabled in domain_vgic_init to verify
> >> the GIC is supporting the version of the vGIC.
> > 
> > That's a shame.
> > 
> > vgic_vN_init would have been the ideal place to test for this, which
> > would have kept everything in one place, but you've just nuked that and
> > I suppose don't want it coming back.
> 
> I dropped vgic_vN_init because it was only setting the ops. I don't mind
> to remove the patch #3 and move all the structure in vgic-v*.c.
> It will be a lot cleaner.

That sounds good, thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel