Re: [Xen-devel] [v4][PATCH 12/19] tools/libxl: passes rdm reservation policy

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 07/01/2015 02:30 AM, Chen, Tiejun wrote:
> On 2015/7/1 0:11, George Dunlap wrote:
>> On Tue, Jun 23, 2015 at 10:57 AM, Tiejun Chen <tiejun.chen@xxxxxxxxx>
>> wrote:
>>> This patch passes our rdm reservation policy inside libxl
>>> when we assign a device or attach a device.
>>
>> Actually, it looks like what you need to do here, both for this patch
>> and the previous one is to add "rdm_reserve" to libxlu_pci.c, so that
>> it gets handled on a per-device level just like permissive,
>> msitranslate, &c.  That would make it Just Work for both domain config
>> and for the pci hotplug (and any other toolstacks using the xlu
>> functions to parse BDFs).
>>
> 
> We'd like to separate this kind of thing into two patches respectively
> to make this patch series bisectable and readable. And actually this
> split is suggested by Wei during our previous review, I think his advice
> should make sense.

I'm not only suggesting changing the layout of the patches; I'm
suggesting modifying the functionality.

In patch 12 you add a new command-line parameter to xl; so that you have
to type something like this:

# xl pci-attach ubuntu01 01:00.1,msitranslate=1 relaxed

What I'm saying is that you can drop the xl part of that patch entirely,
because once you have the xlu code in, you can just do this:

# xl pci-attach ubuntu01 01:00.1,msitranslate=1,rdm_reserve=relaxed

This has the positive advantage that you can copy and paste the same
string into both the xl command and the xl config file.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel