Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ed White writes ("Re: [PATCH v3 05/13] x86/altp2m: basic data structures and 
support routines."):
...
> In every case, this is because I wrote the code to conform with the style
> of the surrounding code. I'll fix them all, but I think the maintainers
> need to be clear about which is more important -- following the coding
> style or following the style of the surrounding code.

Sadly there are indeed inconsistent style problems like this in
various bits of the codebase.  I agree with Ed that maintainers need
to be clear about what is more important.

I also think that maintainers should (a) when making style complaints,
be aware if the existing code style is inconsistent or wrong and
(b) where it is, consider whether to grant submitters some leeway.

That doesn't mean that it's not appropriate to ask a submitter to
conform to a particular style; but it is important to remain
respectful.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel