[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 20/29] tools/libxl: Convert a legacy stream if needed

Andrew Cooper writes ("[PATCH v4 20/29] tools/libxl: Convert a legacy stream if 
> For backwards compatibility, a legacy stream needs converting before
> it can be read by the v2 stream logic.
> This causes the v2 stream logic to need to juggle two parallel tasks.
> check_all_finished() is introduced for the purpose of joining the
> tasks in both success and error cases.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> +    /* If we started a conversion helper, we took ownership of its carefd. */
> +    if (stream->chs.v2_carefd)
> +        libxl__carefd_close(stream->chs.v2_carefd);

I have just spotted that this if is not needed because
libxl__carefd_close(NULL) is a no-op (and I have just checked that the
implementation matches the documentation!)

If you need to respin for some other reason you might want to adjust
this, but I won't mind if you don't.  Otherwise, you or I might want
to propose a cleanup patch for this later.

Note that this is not the only occurrence.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.