Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

["Sahita, Ravi" <ravi.sahita@xxxxxxxxx>]

>From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>Sent: Thursday, July 23, 2015 9:16 AM
>
>>>> On 23.07.15 at 18:08, <george.dunlap@xxxxxxxxxx> wrote:
>> On 07/23/2015 03:51 PM, Sahita, Ravi wrote:
>>>>> +int p2m_destroy_altp2m_by_id(struct domain *d, unsigned int idx) {
>>>>> +    struct p2m_domain *p2m;
>>>>> +    int rc = -EINVAL;
>>>>> +
>>>>> +    if ( !idx || idx > MAX_ALTP2M )
>>>>
>>>>     >= (and then also elsewhere further down)?
>>>>
>>>
>>> Right.
>>
>> [snip]
>>
>>> Just wanted to make sure these are also ok to do post 4.6
>>
>> Well the off-by-one errors certainly need to be fixed for 4.6.
>>
>> If this was the only thing holding it up, the committer could fix it
>> up on check-in, or we could take a fix-up patch afterwards.

This was it for 4.6, others were post 4.6 - so if this could be done by the 
committer that would be great George - thanks, Ravi

>
>Sure, but on this one in particular I intentionally gave my ack only for the 
>non-
>mm parts, hoping you would do another pass over them (and then hopefully
>ack them).
>
>Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel