[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

Hi Stefano,

On 05/08/15 10:49, Stefano Stabellini wrote:
>>  /* VIRT <-> MACHINE conversion */
>>  #define virt_to_mfn(v)              (pfn_to_mfn(virt_to_pfn(v)))
>> @@ -96,7 +115,7 @@ static inline bool set_phys_to_machine(unsigned long pfn, 
>> unsigned long mfn)
>>  bool xen_arch_need_swiotlb(struct device *dev,
>>                         unsigned long pfn,
>> -                       unsigned long mfn);
>> +                       unsigned long dfn);
>>  unsigned long xen_get_swiotlb_free_pages(unsigned int order);
> You missed a bunch of dfn->bfn renamings.

Sorry, I forgot to double check that before sending the patch. I will
fix it in the next version.

> Aside from those and the commit message error:
> Reviewed-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Thank you!


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.