Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 5 Aug 2015, Julien Grall wrote:
> Hi Shannon,
> 
> On 05/08/15 10:29, Shannon Zhao wrote:
> >>
> >>> 3)DOM0 how to get grant table and event channel irq informations
> >>>   As said above, we assign the hypervisor_id be "XenVMM" to tell DOM0
> >>>   that it runs on Xen hypervisor.
> >>>   Then save the start address and size
> >>>   of grant table in domain->grant_table->start_addr and
> >>>   domain->grant_table->size. DOM0 can call a new hypercall
> >>>   GNTTABOP_get_start_addr to get these info.
> >>>   Same to event channel, we've already save interrupt number in
> >>>   d->arch.evtchn_irq, so DOM0 can call a new hypercall EVTCHNOP_get_irq
> >>>   to get the irq.
> >>
> >> It would be nice to go down into more details and write the parameters
> >> of the hypercalls in the doc as they will become a newly supported ABI.
> >>
> > The parameters of GNTTABOP_get_start_addr is like below:
> 
> The hypercall is not only giving the start but also the size. So I would
> rename into GNTTABOP_get_region

I agree


> >     struct gnttab_get_start_addr {
> >         /* IN parameters */
> >         domid_t dom;
> 
> The domain ID is not necessary. We only want to retrieve grant table
> region of the current domain.

Most other GNTTABOP have a domid parameter, so for uniformity I would
keep it.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel