[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/x86: Fix up rules when forcing -mno-sse

On Wed, Aug 12, 2015 at 11:12 AM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> On 12/08/15 17:03, Doug Goldstein wrote:
>> On Wed, Aug 12, 2015 at 10:38 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>>> On 12.08.15 at 17:23, <cardoe@xxxxxxxxxx> wrote:
>>>> From: Nathan Rossi <nathan.rossi@xxxxxxxxxx>
>>>> * When forcing -mno-sse specify -mfpmath=387 to avoid the fallback
>>>>   warning
>>> "the fallback warning" being what? I've never seen any, and I don't
>>> think I've ever heard anyone else say there was one.
>>> Apart from that I don't think -mfpmath=387 is what we want - we'd
>>> better tell the compiler to not use x87 registers at all.
> Agreed.
> However, a git grep shows:
> crypto/vmac.c:1098:    double cpb;
> crypto/vmac.c:1158:
> ((double)CLOCKS_PER_SEC*speed_lengths[i]*speed_iters[i]));
> which I suspect might need fixing.

Looks like that only comes in when VMAC_RUN_TESTS is defined. That code
is inside a main().

Doug Goldstein

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.