Re: [Xen-devel] [PATCH v2 2/2] xen/arm: support gzip compressed kernels

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 1 Sep 2015, Ian Campbell wrote:
> On Tue, 2015-09-01 at 15:57 +0100, Stefano Stabellini wrote:
> > 
> > > I'm not sure to see how this would work. Any call to 
> > > alloc_xenheap_pages
> > > should be follow by a called to free_xenheap_pages.
> > > But when freeing the modules, we are using init_heap_pages.
> > > I don't think they are similar.
> > 
> > Actually init_heap_pages is just a wrapper around free_heap_pages, like
> > free_xenheap_pages. I think it is safe to call init_heap_pages, on
> > memory allocated by alloc_xenheap_pages.
> 
> That probably depends on lots of things, in particular the setting of
> CONFIG_SEPARATE_XENHEAP and in any case I think it should be avoided as a
> matter of principal.
> 
> Also, modules are freed to the domheap not the xenheap. 
> 
> Maybe it would be best if this memory was allocated from there?

Yes, you are right, it would definitely be better.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel