Re: [Xen-devel] [PATCH] build: update top-level make help

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-09-02 at 09:22 -0500, Doug Goldstein wrote:
> On 9/2/15 9:14 AM, Jan Beulich wrote:
> > > > > On 02.09.15 at 15:34, <ian.campbell@xxxxxxxxxx> wrote:
> > > On Wed, 2015-09-02 at 07:14 -0600, Jan Beulich wrote:
> > > > > > > On 02.09.15 at 15:09, <cardoe@xxxxxxxxxx> wrote:
> > > > > On Wed, Sep 2, 2015 at 3:28 AM, Jan Beulich <jbeulich@xxxxxxxx> 
> > > > > wrote:
> > > > > > > > > Doug Goldstein <cardoe@xxxxxxxxxx> 09/01/15 10:10 PM >>>
> > > > > > > --- a/Makefile
> > > > > > > +++ b/Makefile
> > > > > > > @@ -228,16 +228,23 @@ help:
> > > > > > > @echo '  install-stubdom       - build and install the 
> > > > > > > stubdomain 
> > > > > > > images'
> > > > > > > @echo '  install-docs          - build and install user 
> > > > > > > documentation'
> > > > > > > @echo ''
> > > > > > > -      @echo 'Building targets:'
> > > > > > > +      @echo 'Local dist targets:'
> > > > > > > @echo '  dist                  - build and install everything 
> > > > > > > into 
> > > > > > > local dist directory'
> > > > > > > @echo '  world                 - clean everything then make 
> > > > > > > dist'
> > > > > > > -      @echo '  xen                   - build and install Xen 
> > > > > > > 
> > > > > > > hypervisor'
> > > > > > > -      @echo '  tools                 - build and install 
> > > > > > > tools'
> > > > > > > -      @echo '  stubdom               - build and install the 
> > > > > > > 
> > > > > > > stubdomain images'
> > > > > > > -      @echo '  docs                  - build and install 
> > > > > > > user 
> > > > > > > documentation'
> > > > > > 
> > > > > > Why are these being removed? At least the xen and tools ones 
> > > > > > work 
> > > > > > fine for me.
> > > > > 
> > > > > In the makefile they're marked as "legacy" and they are wired 
> > > > > straight
> > > > > to their "dist-" equivalents.
> > > > 
> > > > But still they're there and they work (and they're faster to type 
> > > > than
> > > > their "dist-" equivalents).
> > > 
> > > If they are legacy then it is correct to not list them here.
> > 
> > Hmm - why does "legacy" imply "not documented here"?
> > 
> > But anyway - I don't mean to stand in the way of you committing the
> > patch as is, as long as those (legacy) build targets don't go away.
> > 
> > Jan
> > 
> 
> I definitely had no intention of removing them. I was merely trying to
> update the help output to match what I saw when reading the contents of
> the Makefile.
> 
> Do I still need to resubmit or is my S-o-b on the ML ok?

A post-facto S-o-b like you did is fine.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel