[Xen-devel] netback grant copying issues

["Jan Beulich" <JBeulich@xxxxxxxx>]

Ian, Wei,

I seem to be seeing two issues in the grant copy handling of netback,
solely from code inspection:

1) Shouldn't MAX_GRANT_COPY_OPS, to take care of the copying
the header may require, be
((MAX_SKB_FRAGS + 1) * XEN_NETIF_RX_RING_SIZE)?

2) xenvif_gop_frag_copy() may set up any number of copy_gop-s
per meta slot, yet xenvif_check_gop() checks only one.

Apart from that I find it puzzling that the comment ahead of
xenvif_gop_frag_copy() talks about flipping interfaces, while iirc
all flipping code has long been deleted from the upstream driver.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel