Re: [Xen-devel] [OSSTest Nested v12 05/21] Honour $xopts{ExtraConfig} and use it to enable nestedhvm

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Robert Ho writes ("[OSSTest Nested v12 05/21] Honour $xopts{ExtraConfig} and 
use it to enable nestedhvm"):

Your summary line says `Honour $xopts{ExtraConfig}' but I think this
was actually done in 2011 in dc801db7 "Osstest: prepareguest: honour
xopt ExtraConfig".

I think this patch honours the enable_nestedhvm guest setting, ie the
runvar GUEST_enable_nestedhvm or enable_nestedhvm.

Having thought about this, I think it would be better if the guest var
were called `nestedhvm_enable'.  Sorry to ask for this change now, but
could you change that please (and the corresponding later parts that
set it, of course) ?

> +    my $extra_config = '';
> +    $extra_config .= "nestedhvm=1\n"
> +        if guest_var($gho,"enable_nestedhvm",'false') =~ m/true/;

This should use guest_var_boolean (which I think was probably
introduced after you wrote this code).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel