[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 for-4.6] libxl: handle read-only drives with qemu-xen
On Wed, 16 Sep 2015, Wei Liu wrote: > On Tue, Sep 15, 2015 at 06:53:53PM +0100, M A Young wrote: > > On Tue, 15 Sep 2015, Stefano Stabellini wrote: > > > > > } else { > > > + if (!disks[i].readwrite) { > > > + LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "qemu-xen doesn't > > > support read-only disk drivers"); > > > + return ERROR_INVAL; > > > + } > > > + > > > > Is ERROR_INVAL the right error to return? I get > > > > libxl_dm.c: In function 'libxl__build_device_model_args_new': > > libxl_dm.c:807:28: error: return makes pointer from integer without a cast > > [-Werror=int-conversion] > > return ERROR_INVAL; > > ^ > > cc1: all warnings being treated as errors > > > > when I try to build xen with the proposed patch. NULL is returned when > > there is a problem in other places in this function. > > > > I don't follow. > > The function in question is libxl__build_device_model_args_new, which > returns an integer. And there are other places in that function that > return ERROR_*. > > Do I miss anything? > > Wei. Hang on, I think it is a case of 4.6 != 4.5 (which is what I was building on). So we probably just need a fixed version for earlier versions of xen. Michael Young _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |