Re: [Xen-devel] [PATCH v7 04/17] vt-d: VT-d Posted-Interrupts feature detection

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.15 at 10:28, <feng.wu@xxxxxxxxx> wrote:
> VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt.
> With VT-d Posted-Interrupts enabled, external interrupts from
> direct-assigned devices can be delivered to guests without VMM
> intervention when guest is running in non-root mode.
> 
> Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit ...

> @@ -2220,6 +2229,7 @@ int __init intel_vtd_setup(void)
>      iommu_passthrough = 0;
>      iommu_qinval = 0;
>      iommu_intremap = 0;
> +    iommu_intpost = 0;
>      return ret;
>  }

... I think this clearing of flags (which you add as well as what was
there already) doesn't really belong here (but instead should again
be taken care of by generic IOMMU code).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel