Re: [Xen-devel] [PATCH v7 05/17] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.15 at 10:28, <feng.wu@xxxxxxxxx> wrote:
> Extend struct pi_desc according to VT-d Posted-Interrupts Spec.
> 
> Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
> v7:
> - Coding style.

Are you sure?

> --- a/xen/include/asm-x86/hvm/vmx/vmcs.h
> +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h
> @@ -80,8 +80,18 @@ struct vmx_domain {
>  
>  struct pi_desc {
>      DECLARE_BITMAP(pir, NR_VECTORS);
> -    u32 control;
> -    u32 rsvd[7];
> +    union {
> +        struct {
> +        u16     on     : 1,  /* bit 256 - Outstanding Notification */
> +                sn     : 1,  /* bit 257 - Suppress Notification */
> +                rsvd_1 : 14; /* bit 271:258 - Reserved */
> +        u8      nv;          /* bit 279:272 - Notification Vector */
> +        u8      rsvd_2;      /* bit 287:280 - Reserved */
> +        u32     ndst;        /* bit 319:288 - Notification Destination */
> +        };

Clearly the body of the structure is still mis-indented.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel