Re: [Xen-devel] [PATCH v2] xen/keyhandler: Rework keyhandler infrastructure

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/09/15 11:43, Jan Beulich wrote:
> > > > On 24.09.15 at 12:36, <andrew.cooper3@xxxxxxxxxx> wrote:
> > > > +void register_irq_keyhandler(unsigned char key,
> > > > +                             irq_keyhandler_fn_t *fn,
> > > > +                             const char *desc,
> > > > +                             bool_t diagnostic);
> > > I wonder whether the last parameter is really useful here.
> > Yes.  There are diagnostic irq_keyhandlers, 'd' for example.
> I know; I was wondering if we would ever reasonably gain ones
> outside of keyhandler.c.
I am not sure, but as I said, it should be present for completeness.  
The extra incurred overhead is not an issue.
~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel