Re: [Xen-devel] [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> +  # OpenStack needs access to libvirt from a user.
> +  target_cmd_root($ho, <<END);
> +    cat >> /etc/libvirt/libvirtd.conf <<EOF
> +unix_sock_group = "libvirt"
> +unix_sock_ro_perms = "0777"
> +unix_sock_rw_perms = "0770"
> +EOF
> +END

One small nit on this, which is that it isn't idempotent, i.e. running this
step on the same host repeatedly (common in standalone mode) will keep
adding those lines to the conf file.

If you care then possible solutions:

Use target_editfile_root() to filter the lines out and then re-add them.
See setupboot_grub2  and the handling of GRUB_ENABLE_XEN_UEFI_CHAINLOAD

Use grep (3 times?) to decide if you need to append the given line.

Modify the file in the dist file in ts-libvirt-build so it applies to all
test cases and not just this one.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel