Re: [Xen-devel] [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy 
OpenStack on a host with devstack"):
> On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> > +  # OpenStack needs access to libvirt from a user.
> > +  target_cmd_root($ho, <<END);
> > +    cat >> /etc/libvirt/libvirtd.conf <<EOF
> > +unix_sock_group = "libvirt"
> > +unix_sock_ro_perms = "0777"
> > +unix_sock_rw_perms = "0770"
> > +EOF
> > +END
> 
> One small nit on this, which is that it isn't idempotent, i.e. running this
> step on the same host repeatedly (common in standalone mode) will keep
> adding those lines to the conf file.
> 
> If you care then possible solutions:

I agree with Ian C that this is a nit.  However, provided that libvirt
doesn't mind if the lines are duplicated, I think this is tolerable.
It will only occur in by-hand testing.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel