Re: [Xen-devel] [OSSTEST PATCH 2/2] make-flight: create the vNUMA HVM test job

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Oct 06, 2015 at 10:33:24AM +0200, Dario Faggioli wrote:
> On Tue, 2015-10-06 at 09:23 +0100, Ian Campbell wrote:
> > On Mon, 2015-10-05 at 17:41 +0100, Wei Liu wrote:
> 
> > > We don't need to make ts-migrate-support-check fail. It is fine for
> > > the
> > > actual migration test to fail at the beginning as it won't block
> > > the
> > > push gate. It's conceivable that vNUMA guest will be able to
> > > migrate in
> > > the future. When that comes true, the actual migration test will
> > > pass.
> > 
> > I think the point was that if the migration tests fails then all
> > subsequent
> > test steps won't get run at all (apart from leak check & log
> > collection
> > etc).
> > 
> By "test steps" you mean things like other ts-* within the same (vNUMA)
> job? Or something different, e.g., other tests on the same host, etc?
> 
> If the former (which I think is the case), that's not really a big
> deal, as there are no other steps. :-)
> 
> > Whereas if ts-migrate-support-check fails then the migrations will be
> > skipped and those other tests will be run.
> > 
> The above being said, I wasn't sure how to procede myself. I went for
> this approach, following Wei's advice (on IRC), and I still think it's
> a valid one, in line with how new tests have been handled since now...
> unless there are downsides that I'm not seeing. For example, would the
> failure be sticky, i.e., this test will be kept on the same host,
> preventing other tests to run there?
> 

We had a (wrong) assumption that even if the migration test fails the
rest test steps will still run. Ian said this is not true. All
subsequent test steps except for log collection will be skipped, e.g.
guest-start.repeat / guest-stop.repeat etc.

Wei.

> In any case, I'd be fine with tweaking ts-saverestore-support-check
> (it's that one that fails, even before the migration-check one), just
> let me know what you prefer. :-)
> 
> Regards,
> Dario
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel