Re: [Xen-devel] [PATCH v2 6/9] xen/arm: vgic: Introduce a new field to store the rank index and use it

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-10-05 at 13:51 +0100, Julien Grall wrote:
> Having in hand the index for the rank is very handy to avoid computing
> it everytime.

"every time".

> For now, use it when enabling/disabling the vIRQs rather than a formula
> which is not obvious to understand.
> 
> Also drop the comments which where wrong because a shift by DABT_WORD

"were" instead of "where".

> will not give the IRQ number but the index of the register.

You forgot your S-o-b.

Apart from those:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel