Re: [Xen-devel] [PATCH v2 3/9] xen/arm: io: Support sign-extension for every read access

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 06/10/15 14:47, Ian Campbell wrote:
> On Mon, 2015-10-05 at 13:51 +0100, Julien Grall wrote:
>> [...]
>> +    /*
>> +     * Sign extend if required.
>> +     * Note that we expect the read handler to have zeroed the bit
>> +     * unused in the register.
> 
> You were (correctly) going to change this to 
>     Note that we expect the read handler to have zeroed the bits outside the
>     requested access size.

Right and I forgot to update the patch :/.

> Apart from that (which I can fix on commit):
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thank you!

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel