Re: [Xen-devel] [PATCH XEN v3 02/22] tools: Refactor "xentoollog" into its own library

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH XEN v3 02/22] tools: Refactor "xentoollog" into 
its own library"):
> In attempting to disaggregate libxenctrl I found that many of the
> pieces were going to want access to this library, so split it out (as
> it probably should always have been).
> 
> Various build adjustments are needed. In particular things which use
> xtl_* themselves now need to explicity link against the library.
> 
> This has a nice side effect which is that users of libxl no longer
> need to link against libxenctrl just to create a logger, which was
> counter to the principal that applications using libxl shouldn't be
> required to look behind the curtain. This means that xl no longer
> links against libxenctrl.
> 
> The new library uses a version script to ensure that only expected
> symbols are exported and to version them such that ABI guarantees can
> be kept in the future.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This patch looks plausible but it's hard to review because all of the
code motion.  Did you generate the series with git-format-patch -M ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel