Re: [Xen-devel] [PATCH 5/5] raisin: Add XEN_CONFIG_EXTRA to config file

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 14 Oct 2015, George Dunlap wrote:
> Allowing the user to enable or disable specific functionality, such as
> stubdoms.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

I don't like this very much: if we want to disable stubdoms by default
with all configs, then I would prefer to simply add --disable-stubdom to
components/xen without introducing XEN_CONFIG_EXTRA.

Otherwise if we want to give users the chance to add an extra config
option, I would introduce a generic way to do that, so that people can
use it with any components they want, QEMU, libvirt, etc.


>  components/xen        | 2 +-
>  configs/config-4.5    | 4 ++++
>  configs/config-4.6    | 4 ++++
>  configs/config-master | 4 ++++
>  4 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/components/xen b/components/xen
> index 4c37cca..06806b5 100644
> --- a/components/xen
> +++ b/components/xen
> @@ -53,7 +53,7 @@ function xen_build() {
>          ovmf_opt="--enable-ovmf 
> --with-system-ovmf="$BASEDIR"/ovmf-dir/ovmf.bin"
>      fi
>      ./configure --prefix=$PREFIX 
> --with-system-qemu=$PREFIX/lib/xen/bin/qemu-system-i386 \
> -        --disable-qemu-traditional --enable-rombios $seabios_opt $ovmf_opt
> +        --disable-qemu-traditional --enable-rombios $seabios_opt $ovmf_opt 
> $XEN_CONFIG_EXTRA
>      $RAISIN_MAKE
>      $RAISIN_MAKE install DESTDIR="$INST_DIR"
>      cd "$BASEDIR"
> diff --git a/configs/config-4.5 b/configs/config-4.5
> index e3b92d5..1fe86c7 100644
> --- a/configs/config-4.5
> +++ b/configs/config-4.5
> @@ -41,6 +41,10 @@ LIBVIRT_REVISION="origin/xen-tested-master"
>  OVMF_REVISION="cb9a7ebabcd6b8a49dc0854b2f9592d732b5afbd"
>  LINUX_REVISION="master"
>  
> +# Per-project options
> +## Passed to "./configure" when building Xen.  Use to enable or disable 
> specific features
> +# XEN_CONFIG_EXTRA="--disable-stubdom"
> +
>  # Tests
>  ## All tests: busybox-pv busybox-hvm
>  ## ENABLED_TESTS is the list of test run by raise test
> diff --git a/configs/config-4.6 b/configs/config-4.6
> index ebd45e7..623d43c 100644
> --- a/configs/config-4.6
> +++ b/configs/config-4.6
> @@ -41,6 +41,10 @@ LIBVIRT_REVISION="origin/xen-tested-master"
>  OVMF_REVISION="cb9a7ebabcd6b8a49dc0854b2f9592d732b5afbd"
>  LINUX_REVISION="master"
>  
> +# Per-project options
> +## Passed to "./configure" when building Xen.  Use to enable or disable 
> specific features
> +# XEN_CONFIG_EXTRA="--disable-stubdom"
> +
>  # Tests
>  ## All tests: busybox-pv busybox-hvm
>  ## ENABLED_TESTS is the list of test run by raise test
> diff --git a/configs/config-master b/configs/config-master
> index b218708..7d2f822 100644
> --- a/configs/config-master
> +++ b/configs/config-master
> @@ -40,6 +40,10 @@ LIBVIRT_REVISION="origin/xen-tested-master"
>  OVMF_REVISION="origin/xen-tested-master"
>  LINUX_REVISION="master"
>  
> +# Per-project options
> +## Passed to "./configure" when building Xen.  Use to enable or disable 
> specific features
> +# XEN_CONFIG_EXTRA="--disable-stubdom"
> +
>  # Tests
>  ## All tests: busybox-pv busybox-hvm
>  ## ENABLED_TESTS is the list of test run by raise test
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel