Re: [Xen-devel] [PATCH 5/5] raisin: Add XEN_CONFIG_EXTRA to config file

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 16/10/15 14:53, Stefano Stabellini wrote:
> On Wed, 14 Oct 2015, George Dunlap wrote:
>> Allowing the user to enable or disable specific functionality, such as
>> stubdoms.
>>
>> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
> I don't like this very much: if we want to disable stubdoms by default
> with all configs, then I would prefer to simply add --disable-stubdom to
> components/xen without introducing XEN_CONFIG_EXTRA.
> 
> Otherwise if we want to give users the chance to add an extra config
> option, I would introduce a generic way to do that, so that people can
> use it with any components they want, QEMU, libvirt, etc.

You did notice that this config option is disabled by default, right?  I
added the line commented-out as an example of the sort of thing you
might want to do.

I don't think we want to disable stubdoms by default across the board.

I wouldn't object to adding empty config variables to the other
components; I just don't have a good way to test them at the moment.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel