Re: [Xen-devel] [PATCH 02/10] x86/mm: override stored file names for multiply built sources

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.10.15 at 14:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 20/10/15 11:39, Jan Beulich wrote:
>> To make it possible to tell apart the static symbols therein, use their
>> object file names instead of their source ones.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> In principle, a very good idea.
> 
> Is it perhaps worth having the build runes pass in a -D value instead,
> so as to avoid the .file reference getting stale?

They're not required to be in sync.

>> --- a/xen/arch/x86/mm/guest_walk.c
>> +++ b/xen/arch/x86/mm/guest_walk.c
>> @@ -29,6 +29,8 @@
>>  #include <asm/page.h>
>>  #include <asm/guest_pt.h>
>>  
>> +/* Allow uniquely identifying static symbols in the 3 generated objects. */
>> +asm(".file \"guest_walk_" __stringify(GUEST_PAGING_LEVELS) ".o\"");
> 
> You should probably have a semicolon or newline at the end, to avoid
> interacting with whatever the next directive the compiler chooses to
> emit is.

We don't do this elsewhere (and the compiler takes care of this
anyway), so why should we care to do so here?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel