Re: [Xen-devel] [PATCH 05/10] x86/mm: build map_domain_gfn() just once

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.10.15 at 14:54, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 20/10/15 11:41, Jan Beulich wrote:
>> It doesn't depend on GUEST_PAGING_LEVELS.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> TBD: To ensure no dependency on GUEST_PAGING_LEVELS, would it perhaps
>>      be better to move the function to a file compiled just once?
> 
> +1  it probably fits best in p2m.c, although none of the surrounding
> files is a particularly good fit.
> 
> If there are other generic helpers, it might be worth making a common.c

That's the thing - I didn't spot any, and for just this function I didn't
want to introduce a new one.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel