Re: [Xen-devel] [PATCH 3/6] xen/common: grant_table: Avoid to shadow "frame" in __gnttab_map_grant_ref

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.10.15 at 16:39, <julien.grall@xxxxxxxxxx> wrote:
> The variable "frame" is declared twice within the function
> __gntab_map_grant_ref.  This makes the code quite confusing to read.
> 
> The second definition is not useful as the first one is never used
> until then. So drop it.

That's not fully correct - the function scope variable has an intializer.
What makes the change correct is the fact the this initializer is there
for no reason. So a really complete patch would have deleted the
initializer at once.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel