[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5/6] xen/common: sched: Avoid to shadow the variable "cur" in runq_tickle

To: Jan Beulich <JBeulich@xxxxxxxx>
From: Julien Grall <julien.grall@xxxxxxxxxx>
Date: Tue, 27 Oct 2015 17:00:27 +0000
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Delivery-date: Tue, 27 Oct 2015 17:02:22 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 27/10/15 16:27, Jan Beulich wrote:
>>>> On 27.10.15 at 16:39, <julien.grall@xxxxxxxxxx> wrote:
>> The variable "cur" is declared twice within "cur". However the top
>> declaration could be re-used avoiding re-declaring another time the
>> variable.
> 
> I suppose the second "cur" was meant to be "runq_tickle()".

Yes.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH 0/6] Remove some usage of shadow variable
  - From: Julien Grall
- [Xen-devel] [PATCH 5/6] xen/common: sched: Avoid to shadow the variable "cur" in runq_tickle
  - From: Julien Grall
- Re: [Xen-devel] [PATCH 5/6] xen/common: sched: Avoid to shadow the variable "cur" in runq_tickle
  - From: Jan Beulich

Prev by Date: Re: [Xen-devel] [PATCH 4/6] xen/common: memory: Avoid to shadow the variable "d" in do_memory_op
Next by Date: [Xen-devel] [PATCH] oxenstored: fix short-write issue
Previous by thread: Re: [Xen-devel] [PATCH 5/6] xen/common: sched: Avoid to shadow the variable "cur" in runq_tickle
Next by thread: [Xen-devel] [PATCH 2/6] xen/common: domain: Avoid to shadow the variable "d" in do_vcpu_op
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.