Re: [Xen-devel] [PATCH 0/6] Remove some usage of shadow variable

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Tue, Oct 27, 2015 at 4:03 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 27.10.15 at 16:39, <julien.grall@xxxxxxxxxx> wrote:
>> I'd like to have some input to know whether turning on -Wshadow would be
>> sensible in the future.
>
> I think there are cases where using a shadowed variable might make
> sense, and hence I wouldn't want to see the warning turned on by
> default.

Hmm, I'm having trouble coming up with good uses off the top of my
head.  And are there any uses for which the value outweighs the value
of having the warning?

And in line with my response to Andrew -- could we enable -Wshadow
until we find a use for shadowing whose value outweighs the risks of
building without it?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel