Re: [Xen-devel] [PATCH] x86/P2M: consolidate handling of types not requiring a valid MFN

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/11/15 14:52, Jan Beulich wrote:
> As noted regarding the mixture of checks in p2m_pt_set_entry(),
> introduce an new P2M type group allowing to be used everywhere we

"a new P2M"

> just care about accepting operations with either a valid MFN or a type
> permitting to be used without (valid) MFN.
>
> Note that p2m_mmio_dm is not included in P2M_NO_MFN_TYPES, as for the
> intended purpose that one ought to be treated similar to p2m_invalid
> (perhaps the two should ultimately get folded anyway).

I seem to recall that p2m_invalid is still required to make the default
ioreq server infrastructure work with older qemu's

We really should see about cleaning the two up however.

>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

You probably also want to note that PoD superpages are now INVALID_MFN
rather than _mfn(0), but code wise,

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel