Re: [Xen-devel] [OSSTEST PATCH 21/22] Serial: Factor out Osstest::Serial::keys_real

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-11-10 at 19:53 +0000, Ian Jackson wrote:
> The sympathy and xenuse serial modules had too much in common.ÂÂFactor
> out the common code, which is now responsible for
> Â - knowledge of the Xen console switch
> Â - splitting strings up into individual keys
> Â - timing decisions
> Â - error trapping and logging
> 
> This new class is an abstract base class for the concrete serial
> method classes, and calls back to its derived class to prepare, send
> each actual key, and shut down.
> 
> There is some functional change: notably, after failure to send the
> first debug key, sending the remainder will not be attempted.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel