Re: [Xen-devel] [PATCH XEN v5 13/23] tools: Refactor foreign memory mapping into libxenforeignmemory

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH XEN v5 13/23] tools: Refactor foreign memory 
mapping into libxenforeignmemory"):
> On Wed, 2015-11-11 at 15:13 +0000, Ian Jackson wrote:
> Are you suggesting:
> 
> void *xenforeignmemory_map(xenforeignmemory_handle *fmem, uint32_t dom,
>                            int prot, const xen_pfn_t *arr,
>                            int err_out[num],
>                            unsigned int num);
> 
> Is that (a var sized array based on another param) really allowed?

Yes, if the array size precedes the array.  Maybe you don't prefer
that.

> Or did you mean as comment like:
> 
> void *xenforeignmemory_map(xenforeignmemory_handle *fmem, uint32_t dom,
>     
>                        int prot, const xen_pfn_t *arr,
>                      
>      int *err_out /*int err_out[num]*/,
>                            unsigned
> int num);

If you don't want to swap the arguments, at the very least

   int err_out[/*num*/]

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel