Re: [Xen-devel] [PATCHv6] 27/28] build: convert CONFIG_COMPAT to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.11.15 at 18:52, <cardoe@xxxxxxxxxx> wrote:
> ---
>  xen/arch/x86/Kconfig | 7 +++++++
>  1 file changed, 7 insertions(+)

This can't be complete - you ought to be deleting the current definition.

> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -25,6 +25,13 @@ config ARCH_DEFCONFIG
>  
>  menu "Architecture Features"
>  
> +config COMPAT
> +     def_bool y
> +     help
> +       32-bit interface support on 64-bit Xen which is used for both
> +       HVM and PV guests. HVMLoader makes 32-bit hypercalls irrespective
> +       of the destination runmode of the guest.

I also don't think help text is very useful here, as it won't appear
anywhere (and due to the hvmloader needs it's also not very
likely to become a user selectable option going forward).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel