Re: [Xen-devel] [PATCHv6] 00/28] Kconfig conversion

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 30/11/15 17:05, Doug Goldstein wrote:
> On 11/30/15 9:51 AM, Julien Grall wrote:
>> Hi Doug,
>>
>> On 24/11/15 17:51, Doug Goldstein wrote:
>>> The following series is a follow on to the Kconfig conversion patch series.
>>> There are still more components to convert however this is the bare minimal
>>> to get everything working and get the options out of the existing makefiles.
>>>
>>> The CONFIG_HAS_ variables are there to match the behavior of the Linux
>>> CONFIG_HAVE_ variables. The purpose is to say that this hardware/profile/env
>>> supports this option while the CONFIG_ variable states that this option was
>>> requested on/off by user intervention.
>>>
>>> The UARTs are now uniformly prefixed as CONFIG_UART_ and dropping most of 
>>> the
>>> CONFIG_HAS_ labeling for them. This means they are now user selectable as
>>> requested by Julien Grall in the prior review. The question I've got is
>>> the old config was just for selecting defaults. Users could enable the OMAP
>>> UART for arm64 for example but I'm not sure if that's valid. Currently this
>>> patchset makes those UARTs not user selectable if they were not previously
>>> defaulted on. But I would like some feedback on this if possible.
>>
>> While you know allow the user to enable a specific UART drivers, I still
>> have the same concern, i.e the default config used for ARM32 and ARM64
>> will have all the UARTs drivers disabled.
> 
> Have you actually tested this? I have built it multiple times locally
> and that's not the case at all. The same UART drivers that are enabled
> in master today and enabled by default everytime.

You are right sorry. I didn't build test it but I looked to the code and
it wasn't obvious that it was enabled by default.

FWIW, Linux is using "default ..." to document the default value. It may
be nice to do the same here too.

config ARM_PATCH_PHYS_VIRT
        bool "Patch physical to virtual translations at runtime" if EMBEDDED
        default y
        depends on !XIP_KERNEL && MMU
        depends on !ARCH_REALVIEW || !SPARSEMEM

Regards,
-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel