[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

>>> On 02.12.15 at 09:23, <huaitong.han@xxxxxxxxx> wrote:
> On Tue, 2015-12-01 at 20:30 +0000, Andrew Cooper wrote:
>> > +#include <asm/i387.h>
>> I can see why you need xstate.h, but I why do you need i387.h ?
> Use vcpu_save_fpu functions.

Which is bogus by itself: That function isn't meant to be used for
purposes like the one you have, e.g. due to its side effect of
clearing ->fpu_dirtied. You really ought to be using a lower level
function here (and I don't think the corresponding struct vcpu
should get altered in any way).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.